Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incident.alerts_count should return count of unique fingerprints instead of alerts #2217

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix: incident.alerts_count should return count of unique fingerprints instead of alerts #2217

merged 3 commits into from
Oct 28, 2024

Conversation

VladimirFilonov
Copy link
Contributor

@VladimirFilonov VladimirFilonov commented Oct 16, 2024 •
edited
Loading

Closes #2213

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:25pm

@VladimirFilonov VladimirFilonov changed the title incident.alerts_count should return count of unique fingerprints instead of alerts fix: incident.alerts_count should return count of unique fingerprints instead of alerts Oct 16, 2024
@VladimirFilonov VladimirFilonov force-pushed the fix/2213-bug-show-count-of-unique-fingerprints-in-the-incident-instead-of-alerts-count branch 5 times, most recently from ca855fa to 4632262 Compare October 18, 2024 08:43
@VladimirFilonov VladimirFilonov mentioned this pull request Oct 18, 2024
Merged
4 tasks
@Matvey-Kuk Matvey-Kuk force-pushed the fix/2213-bug-show-count-of-unique-fingerprints-in-the-incident-instead-of-alerts-count branch from 4632262 to 8635d96 Compare October 18, 2024 09:31
@talboren talboren force-pushed the fix/2213-bug-show-count-of-unique-fingerprints-in-the-incident-instead-of-alerts-count branch from 8635d96 to 2d21e57 Compare October 22, 2024 19:10
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 28, 2024
shahargl
shahargl approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2024
@VladimirFilonov VladimirFilonov merged commit d101552 into main Oct 28, 2024
11 checks passed
@VladimirFilonov VladimirFilonov deleted the fix/2213-bug-show-count-of-unique-fingerprints-in-the-incident-instead-of-alerts-count branch October 28, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahargl shahargl shahargl approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Show count of unique fingerprints in the incident instead of alerts count
2 participants
@VladimirFilonov @shahargl